Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(audit): Update audit-from-cache flag description #2989

Conversation

ssheladiya
Copy link
Contributor

What this PR does / why we need it:
Update audit-from-cache flag description to clearly let the users know about auditing from synced resources from the internal cache

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #2948

Special notes for your reviewer:

Signed-off-by: Siddharth Sheladiya <siddharth_sheladiya@intuit.com>
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 35.98% and project coverage change: -0.53% ⚠️

Comparison is base (e50ee2f) 53.07% compared to head (ad4e1a0) 52.54%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2989      +/-   ##
==========================================
- Coverage   53.07%   52.54%   -0.53%     
==========================================
  Files         135      134       -1     
  Lines       11813    11913     +100     
==========================================
- Hits         6270     6260      -10     
- Misses       5055     5165     +110     
  Partials      488      488              
Flag Coverage Δ
unittests 52.54% <35.98%> (-0.53%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/audit/audit_cache_lister.go 0.00% <0.00%> (ø)
pkg/audit/manager.go 9.83% <ø> (ø)
pkg/cachemanager/aggregator/aggregator.go 77.31% <0.00%> (ø)
pkg/cachemanager/parser/syncannotationreader.go 91.42% <ø> (ø)
pkg/syncutil/stats_reporter.go 17.52% <0.00%> (-3.73%) ⬇️
pkg/cachemanager/cachemanager.go 39.92% <39.92%> (ø)
pkg/controller/config/config_controller.go 57.65% <57.14%> (-5.87%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@acpana acpana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR 🥇

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! LGTM

@sozercan sozercan merged commit e138b24 into open-policy-agent:master Sep 8, 2023
15 checks passed
salaxander pushed a commit to salaxander/gatekeeper that referenced this pull request Sep 13, 2023
…nt#2989)

Signed-off-by: Siddharth Sheladiya <siddharth_sheladiya@intuit.com>
Mattes83 pushed a commit to Mattes83/gatekeeper that referenced this pull request Oct 25, 2023
…nt#2989)

Signed-off-by: Siddharth Sheladiya <siddharth_sheladiya@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

audit: update audit-from-cache flag description
5 participants