-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(audit): Update audit-from-cache flag description #2989
fix(audit): Update audit-from-cache flag description #2989
Conversation
Signed-off-by: Siddharth Sheladiya <siddharth_sheladiya@intuit.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2989 +/- ##
==========================================
- Coverage 53.07% 52.54% -0.53%
==========================================
Files 135 134 -1
Lines 11813 11913 +100
==========================================
- Hits 6270 6260 -10
- Misses 5055 5165 +110
Partials 488 488
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the PR 🥇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you! LGTM
…nt#2989) Signed-off-by: Siddharth Sheladiya <siddharth_sheladiya@intuit.com>
…nt#2989) Signed-off-by: Siddharth Sheladiya <siddharth_sheladiya@intuit.com>
What this PR does / why we need it:
Update
audit-from-cache
flag description to clearly let the users know about auditing from synced resources from the internal cacheWhich issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #2948
Special notes for your reviewer: