fix(helm): add nindent in objectSelector #3071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leewoobin789
force-pushed
the
master
branch
2 times, most recently
from
0cda25a
to
b85c78d
Compare
sozercan
reviewed
Oct 16, 2023
...keeper/templates/gatekeeper-mutating-webhook-configuration-mutatingwebhookconfiguration.yaml
Outdated
Show resolved
Hide resolved
ritazh
reviewed
Oct 17, 2023
...keeper/templates/gatekeeper-mutating-webhook-configuration-mutatingwebhookconfiguration.yaml
Show resolved
Hide resolved
Signed-off-by: leewoobin789 <leewoobin789@gmail.com>
This reverts commit b85c78d. Signed-off-by: leewoobin789 <leewoobin789@gmail.com>
Signed-off-by: leewoobin789 <leewoobin789@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3071 +/- ##
=======================================
Coverage 52.46% 52.46%
=======================================
Files 134 134
Lines 11952 11952
=======================================
Hits 6271 6271
+ Misses 5190 5189 -1
- Partials 491 492 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@sozercan PTAL |
|
@sozercan could you review it once again? :) |
sozercan
approved these changes
Oct 23, 2023
Mattes83
pushed a commit
to Mattes83/gatekeeper
that referenced
this pull request
Oct 25, 2023
Signed-off-by: leewoobin789 <leewoobin789@gmail.com> Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):fixes indentation problem occurred when you specify objectSelector via either
validatingWebhookObjectSelectorormutatingWebhookObjectSelectorSpecial notes for your reviewer:
for instance, adding
validatingWebhookObjectSelectorcauses templating errorError: YAML parse error on gatekeeper/charts/gatekeeper/templates/gatekeeper-validating-webhook-configuration-validatingwebhookconfiguration.yaml: error converting YAML to JSON: yaml: line 33: mapping values are not allowed in this context