Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: drop arm/v7 builds for crd image #3074

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

sozercan
Copy link
Member

@sozercan sozercan commented Oct 17, 2023

What this PR does / why we need it:

registry.k8s.io/kubectl:v1.28.2 does not include 32-bit arm/v7 kubectl, which blocks us from building gatekeeper-crds image for arm/v7

Also fixes a bug in the pre-release CI where we omitted \, this should have been caught there

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:
This is blocking v3.14.0 release so needs to be cherry picked there after merge

Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Copy link
Contributor

@JaydipGabani JaydipGabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (103ae25) 52.42% compared to head (c349fe1) 52.50%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3074      +/-   ##
==========================================
+ Coverage   52.42%   52.50%   +0.07%     
==========================================
  Files         134      134              
  Lines       11952    11952              
==========================================
+ Hits         6266     6275       +9     
+ Misses       5193     5187       -6     
+ Partials      493      490       -3     
Flag Coverage Δ
unittests 52.50% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sozercan sozercan merged commit 780a66a into open-policy-agent:master Oct 17, 2023
15 checks passed
@sozercan sozercan deleted the drop-armv7 branch October 17, 2023 16:56
sozercan added a commit to sozercan/gatekeeper that referenced this pull request Oct 17, 2023
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
sozercan added a commit that referenced this pull request Oct 17, 2023
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Mattes83 pushed a commit to Mattes83/gatekeeper that referenced this pull request Oct 25, 2023
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants