fix: fixes disable cache flow #3132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3132 +/- ##
==========================================
+ Coverage 52.66% 52.68% +0.01%
==========================================
Files 134 134
Lines 11890 11890
==========================================
+ Hits 6262 6264 +2
+ Misses 5141 5140 -1
+ Partials 487 486 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
sozercan
approved these changes
Oct 31, 2023
acpana
pushed a commit
to acpana/gatekeeper
that referenced
this pull request
Nov 16, 2023
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds checks to make sure the external data provider cache is not used when disabled.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #3119
Special notes for your reviewer: