Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: set up go version for govulncheck #3159

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

sozercan
Copy link
Member

@sozercan sozercan commented Nov 15, 2023

What this PR does / why we need it:
by default, govulncheck is picking up go version in the agent. this might flag for vulns inaccurately as we use a floating version using setup-go.

added check-latest to make sure if we get the latest patch version instead of cached version in the agent.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
@sozercan sozercan requested a review from a team as a code owner November 15, 2023 21:28
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (51216ee) 53.18% compared to head (cf2c882) 53.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3159      +/-   ##
==========================================
+ Coverage   53.18%   53.20%   +0.02%     
==========================================
  Files         134      134              
  Lines       11917    11917              
==========================================
+ Hits         6338     6341       +3     
+ Misses       5083     5081       -2     
+ Partials      496      495       -1     
Flag Coverage Δ
unittests 53.20% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sozercan sozercan merged commit aed792f into open-policy-agent:master Nov 21, 2023
16 checks passed
@sozercan sozercan deleted the go-vuln-version branch November 21, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants