Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: log panic in am (#3174) cherry-pick for 3.14 #3180

Merged
merged 1 commit into from Dec 5, 2023

Conversation

acpana
Copy link
Contributor

@acpana acpana commented Nov 30, 2023

Cherry pick of #3174 for 3.14

Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
@acpana acpana changed the title fix: log panic in am (#3174) fix: log panic in am (#3174) cherry-pick for 3.14 Nov 30, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (650f3de) 52.98% compared to head (11c6444) 52.88%.

Files Patch % Lines
pkg/audit/manager.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-3.14    #3180      +/-   ##
================================================
- Coverage         52.98%   52.88%   -0.10%     
================================================
  Files               134      134              
  Lines             11959    11959              
================================================
- Hits               6336     6325      -11     
- Misses             5126     5133       +7     
- Partials            497      501       +4     
Flag Coverage Δ
unittests 52.88% <0.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxsmythe maxsmythe merged commit f07df71 into open-policy-agent:release-3.14 Dec 5, 2023
15 checks passed
openshift-merge-bot bot pushed a commit to stolostron/gatekeeper that referenced this pull request Dec 6, 2023
…pen-policy-agent#3180)

Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants