Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update install.md #3191

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Conversation

Asya-kawai
Copy link
Contributor

Typo perhaps.

What this PR does / why we need it:

I encountered an error as below.

ubuntu@ubuntu-playground:~/gatekeeper$ export DESTINATION_GATEKEEPER_IMAGE=opa-test.sakuracr.jp/gatekeeper
ubuntu@ubuntu-playground:~/gatekeeper$ echo $DESTINATION_GATEKEEPER_IMAGE
opa-test.sakuracr.jp/gatekeeper
ubuntu@ubuntu-playground:~/gatekeeper$ echo $DESTINATION_GATEKEEPER_DOCKER_IMAGE

ubuntu@ubuntu-playground:~/gatekeeper$ make docker-buildx REPOSITORY=$DESTINATION_GATEKEEPER_DOCKER_IMAGE OUTPUT_TYPE=type=registry
if ! docker buildx ls | grep -q container-builder; then\
        docker buildx create --name container-builder --use --bootstrap;\
        docker buildx inspect;\
fi
docker buildx build \
         \
        --build-arg LDFLAGS="-X github.com/open-policy-agent/gatekeeper/v3/pkg/version.Version=v3.15.0-beta.0" \
        --platform="linux/amd64" \
        --output=type=registry \
        -t :latest .
[+] Building 0.0s (0/0)                                                              docker-container:container-builder
ERROR: invalid tag ":latest": invalid reference format
make: *** [Makefile:375: docker-buildx] Error 1

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

The workaround(I use REPOSITORY=$DESTINATION_GATEKEEPER_IMAGE instead of REPOSITORY=$DESTINATION_GATEKEEPER_DOCKER_IMAGE).

ubuntu@ubuntu-playground:~/gatekeeper$ make docker-buildx REPOSITORY=$DESTINATION_GATEKEEPER_IMAGE OUTPUT_TYPE=type=registry
if ! docker buildx ls | grep -q container-builder; then\
        docker buildx create --name container-builder --use --bootstrap;\
        docker buildx inspect;\
fi
docker buildx build \
         \
        --build-arg LDFLAGS="-X github.com/open-policy-agent/gatekeeper/v3/pkg/version.Version=v3.15.0-beta.0" \
        --platform="linux/amd64" \
        --output=type=registry \
        -t opa-test.sakuracr.jp/gatekeeper:latest .
[+] Building 4.9s (13/13) FINISHED                                                   docker-container:container-builder
 => [internal] load build definition from Dockerfile                                                               0.0s
 => => transferring dockerfile: 874B                                                                               0.0s
 => [internal] load metadata for gcr.io/distroless/static:nonroot                                                  0.7s
 => [internal] load metadata for docker.io/library/golang:1.21-bullseye                                            1.2s
 => [internal] load .dockerignore                                                                                  0.0s
 => => transferring context: 116B                                                                                  0.0s
 => [builder 1/4] FROM docker.io/library/golang:1.21-bullseye@sha256:ca78a56712ab89487123b3af2b30052824653730e7ff  0.0s
 => => resolve docker.io/library/golang:1.21-bullseye@sha256:ca78a56712ab89487123b3af2b30052824653730e7ff25271d2f  0.0s
 => [internal] load build context                                                                                  0.6s
 => => transferring context: 805.85kB                                                                              0.5s
 => [stage-1 1/3] FROM gcr.io/distroless/static:nonroot@sha256:91ca4720011393f4d4cab3a01fa5814ee2714b7d40e6c74f25  0.1s
 => => resolve gcr.io/distroless/static:nonroot@sha256:91ca4720011393f4d4cab3a01fa5814ee2714b7d40e6c74f2505f74168  0.1s
 => CACHED [builder 2/4] WORKDIR /go/src/github.com/open-policy-agent/gatekeeper                                   0.0s
 => CACHED [builder 3/4] COPY . .                                                                                  0.0s
 => CACHED [builder 4/4] RUN go build -mod vendor -a -ldflags "-X github.com/open-policy-agent/gatekeeper/v3/pkg/  0.0s
 => CACHED [stage-1 2/3] COPY --from=builder /go/src/github.com/open-policy-agent/gatekeeper/manager .             0.0s
 => exporting to image                                                                                             2.8s
 => => exporting layers                                                                                            0.0s
 => => exporting manifest sha256:961ae7b7d450515ebd5e4c735c2950524c4e4fcf1263763ec19a16d72d6698b0                  0.0s
 => => exporting config sha256:3279b3a6edb86f377366b37284ed6b4375b70f2ee2b0cfabf336217112b189d9                    0.0s
 => => exporting attestation manifest sha256:c65adc1064bf04b1ec20db025418a17a98f0c70f1f30755ea2b51affe12763a4      0.0s
 => => exporting manifest list sha256:effd91ac57d417da92e5dad9c10c6d9984a2776110d75c55e88354a0c581d26c             0.0s
 => => pushing layers                                                                                              1.7s
 => => pushing manifest for opa-test.sakuracr.jp/gatekeeper:latest@sha256:effd91ac57d417da92e5dad9c10c6d9984a2776  1.0s
 => [auth] gatekeeper:pull,push token for opa-test.sakuracr.jp                                                     0.0s
ubuntu@ubuntu-playground:~/gatekeeper$ echo $?
0

ubuntu@ubuntu-playground:~/gatekeeper$ docker pull opa-test.sakuracr.jp/gatekeeper:latest
latest: Pulling from gatekeeper
07a64a71e011: Pull complete
fe5ca62666f0: Pull complete
b02a7525f878: Pull complete
fcb6f6d2c998: Pull complete
e8c73c638ae9: Pull complete
1e3d9b7d1452: Pull complete
4aa0ea1413d3: Pull complete
7c881f9ab25e: Pull complete
5627a970d25e: Pull complete
7471572425a1: Pull complete
Digest: sha256:effd91ac57d417da92e5dad9c10c6d9984a2776110d75c55e88354a0c581d26c
Status: Downloaded newer image for opa-test.sakuracr.jp/gatekeeper:latest
opa-test.sakuracr.jp/gatekeeper:latest

Typo perhaps.

Signed-off-by: Asya-kawai <33394138+Asya-kawai@users.noreply.github.com>
@Asya-kawai Asya-kawai requested a review from a team as a code owner December 14, 2023 02:53
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@maxsmythe maxsmythe changed the title Update install.md docs: Update install.md Dec 22, 2023
@ritazh ritazh merged commit 5978ea8 into open-policy-agent:master Dec 29, 2023
4 checks passed
@Asya-kawai Asya-kawai deleted the patch-1 branch January 7, 2024 05:05
leewoobin789 pushed a commit to softlee-io/gatekeeper that referenced this pull request Apr 1, 2024
Signed-off-by: Asya-kawai <33394138+Asya-kawai@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants