Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add request input struct #3234

Merged

Conversation

salaxander
Copy link
Contributor

What this PR does / why we need it: Part of the docs requested in #66. Gives users documentation on the structure of admission requests.

Signed-off-by: Xander Grzywinski <xandergrzyw@gmail.com>
@salaxander salaxander requested a review from a team as a code owner January 25, 2024 21:30
website/docs/input.md Outdated Show resolved Hide resolved
@@ -138,16 +138,4 @@ kubectl get constraints
```

### Input Review

The `input.review` object stores the [admission request](https://pkg.go.dev/k8s.io/kubernetes/pkg/apis/admission#AdmissionRequest) under evaluation. It has the following fields:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update this as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is updated same as the other one. For whatever reason the display is showing the new line below the deleted bit

Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@salaxander salaxander merged commit e4853bb into open-policy-agent:master Feb 1, 2024
4 checks passed
@salaxander salaxander deleted the docs_admission_input branch February 1, 2024 15:55
leewoobin789 pushed a commit to softlee-io/gatekeeper that referenced this pull request Apr 1, 2024
Signed-off-by: Xander Grzywinski <xandergrzyw@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants