ci: bump k8s matrix #3267
Merged
ci: bump k8s matrix #3267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3267 +/- ##
==========================================
+ Coverage 54.46% 54.50% +0.04%
==========================================
Files 134 134
Lines 12318 12318
==========================================
+ Hits 6709 6714 +5
+ Misses 5113 5109 -4
+ Partials 496 495 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
maxsmythe
approved these changes
Feb 14, 2024
|
Looks like the breakage may not be a flake:
|
maxsmythe
requested changes
Feb 14, 2024
|
yea this needs further investigation |
sozercan
force-pushed
the
bump-k8s-matrix-129
branch
2 times, most recently
from
d9137d7
to
3b1cc4a
Compare
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
sozercan
force-pushed
the
bump-k8s-matrix-129
branch
from
3b1cc4a
to
c98b6f9
Compare
sozercan
force-pushed
the
bump-k8s-matrix-129
branch
from
df7294c
to
ff4d6ab
Compare
|
@maxsmythe updated. there was a change in k8s 1.29 to require certain types for externalIPs kubernetes/kubernetes#119150 |
|
Good find! Kinda weird that not defining that results in a stack trace. |
leewoobin789
pushed a commit
to softlee-io/gatekeeper
that referenced
this pull request
Apr 1, 2024
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
drops eol 1.25, adds 1.29
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: