feat: add disableAudit helm option #3270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zapdor2000@gmail.com <zapdor2000@gmail.com>
DorB-P
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3270 +/- ##
==========================================
+ Coverage 54.48% 54.51% +0.02%
==========================================
Files 134 134
Lines 12318 12318
==========================================
+ Hits 6712 6715 +3
+ Misses 5111 5108 -3
Partials 495 495
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
leewoobin789
pushed a commit
to softlee-io/gatekeeper
that referenced
this pull request
Apr 1, 2024
Signed-off-by: zapdor2000@gmail.com <zapdor2000@gmail.com> Co-authored-by: Max Smythe <smythe@google.com> Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds a flag to the Helm templates to allow users to deploy the chart without the gatekeeper-audit deployment resource using GK in a webhook mode, validating and mutating.
Special notes for your reviewer:
This is functionality I want as someone deploying GK with Helm. Currently, I use Helm and then delete the audit deployment. My use case only requires the validating webhook without other overheads.
The idea for the PR derived from #643