feat: Update audit and controller manager with pod labels (#3240) (cherry pick)

[ghost]

Signed-off-by: James Bruce james.bruce@ba.com
Co-authored-by: Rita Zhang rita.z.zhang@gmail.com
(cherry picked from commit 902a1b4)

What this PR does / why we need it:
Details in #3240

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.91%. Comparing base (f07df71) to head (f09a395).

Additional details and impacted files

@@               Coverage Diff                @@
##           release-3.14    #3284      +/-   ##
================================================
+ Coverage         52.87%   52.91%   +0.04%     
================================================
  Files               134      134              
  Lines             11959    11959              
================================================
+ Hits               6323     6328       +5     
+ Misses             5135     5131       -4     
+ Partials            501      500       -1     

Flag	Coverage Δ
unittests	52.91% <ø> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ghost]

@ritazh Any idea why the linting is failing? This passed for the original PR

[maxsmythe]

Might have been a flake. Rerunning.

[maxsmythe]

It looks like there are some lint errors in the untouched code:

Lint: pkg/mutation/match/match_test.go#L675
G601: Implicit memory aliasing in for loop. (gosec)
Lint: pkg/expansion/system_test.go#L403
G601: Implicit memory aliasing in for loop. (gosec)
Lint: pkg/cachemanager/cachemanager_test.go#L242
G601: Implicit memory aliasing in for loop. (gosec)

@ritazh Fix or ignore?

[maxsmythe]

These are all in tests, so not super worried, personally

[ritazh]

It looks like there are some lint errors in the untouched code:

Lint: pkg/mutation/match/match_test.go#L675 G601: Implicit memory aliasing in for loop. (gosec) Lint: pkg/expansion/system_test.go#L403 G601: Implicit memory aliasing in for loop. (gosec) Lint: pkg/cachemanager/cachemanager_test.go#L242 G601: Implicit memory aliasing in for loop. (gosec)

@ritazh Fix or ignore?

I'm okay ignoring this. I'm unclear why the same version of golangci-lint-action https://github.com/open-policy-agent/gatekeeper/blob/release-3.15/.github/workflows/workflow.yaml#L53 isn't complaining about the same code: https://github.com/open-policy-agent/gatekeeper/blob/release-3.15/pkg/cachemanager/cachemanager_test.go#L255
should I revert my commit?

[maxsmythe]

Revert which commit? I'm okay merging this as-is.

IMO we can call this done unless new commits to main are failing.

[ritazh]

LGTM

[ritazh]

Revert which commit? I'm okay merging this as-is.

IMO we can call this done unless new commits to main are failing.

Taking this as LGTM

I reverted my commit to update the golangci-lint version used in the github action to reduce noise.