fix: fixing metrics views #3307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3307 +/- ##
==========================================
- Coverage 54.49% 54.33% -0.16%
==========================================
Files 134 134
Lines 12329 10258 -2071
==========================================
- Hits 6719 5574 -1145
+ Misses 5116 4180 -936
- Partials 494 504 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JaydipGabani
added a commit
to JaydipGabani/gatekeeper
that referenced
this pull request
Mar 15, 2024
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com> (cherry picked from commit 982a31d)
JaydipGabani
added a commit
to JaydipGabani/gatekeeper
that referenced
this pull request
Mar 15, 2024
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com> (cherry picked from commit 982a31d)
JaydipGabani
added a commit
to JaydipGabani/gatekeeper
that referenced
this pull request
Mar 15, 2024
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com> (cherry picked from commit 982a31d)
leewoobin789
pushed a commit
to softlee-io/gatekeeper
that referenced
this pull request
Apr 1, 2024
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Order of registering views in otel metrics was no in orientation and is causing views to used default configurations instead of custom.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #3303
Special notes for your reviewer: