Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable vap in helm #3329

Merged
merged 2 commits into from Mar 26, 2024
Merged

Conversation

ritazh
Copy link
Member

@ritazh ritazh commented Mar 22, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #3282

Special notes for your reviewer:

@ritazh ritazh requested a review from a team as a code owner March 22, 2024 23:10
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.49%. Comparing base (3350319) to head (ca9a232).
Report is 44 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #3329     +/-   ##
=========================================
  Coverage   54.49%   54.49%             
=========================================
  Files         134      134             
  Lines       12329    10294   -2035     
=========================================
- Hits         6719     5610   -1109     
+ Misses       5116     4175    -941     
- Partials      494      509     +15     
Flag Coverage Δ
unittests 54.49% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ritazh ritazh merged commit c3c3c20 into open-policy-agent:master Mar 26, 2024
17 checks passed
@ritazh ritazh deleted the feat-vap-helm branch March 26, 2024 21:03
leewoobin789 pushed a commit to softlee-io/gatekeeper that referenced this pull request Apr 1, 2024
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add helm chart values for vap generation
4 participants