feat: Enable toggling of deferring to VAP #3335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Smythe <smythe@google.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3335 +/- ##
==========================================
- Coverage 54.49% 46.76% -7.74%
==========================================
Files 134 218 +84
Lines 12329 14784 +2455
==========================================
+ Hits 6719 6913 +194
- Misses 5116 7069 +1953
- Partials 494 802 +308
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ritazh
reviewed
Mar 26, 2024
maxsmythe
changed the title
maxsmythe
force-pushed
the
incorporate-cf-vap-toggle
branch
from
d396df1
to
9a04f45
Compare
Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com> Signed-off-by: Max Smythe <max.smythe@gmail.com>
maxsmythe
force-pushed
the
incorporate-cf-vap-toggle
branch
from
9a04f45
to
bb3a7a8
Compare
JaydipGabani
approved these changes
Mar 27, 2024
sozercan
reviewed
Mar 27, 2024
Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com> Signed-off-by: Max Smythe <max.smythe@gmail.com>
leewoobin789
pushed a commit
to softlee-io/gatekeeper
that referenced
this pull request
Apr 1, 2024
Signed-off-by: Max Smythe <smythe@google.com> Signed-off-by: Max Smythe <max.smythe@gmail.com> Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com> Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Implementation of feature set for VAP generation
Fixes #3331
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: