Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updates docs with new external data provider #3356

Merged

Conversation

nilekhc
Copy link
Contributor

@nilekhc nilekhc commented Apr 17, 2024

What this PR does / why we need it:

Adds docs for Kubernetes API external data providers.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #2716

Special notes for your reviewer:

@nilekhc nilekhc requested a review from a team as a code owner April 17, 2024 18:24
@nilekhc nilekhc force-pushed the update-external-data-provider branch 2 times, most recently from 5611d01 to 714be67 Compare April 17, 2024 18:34
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxsmythe
Copy link
Contributor

Do we also need to change the unversioned docs though?

Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ritazh
Copy link
Member

ritazh commented Apr 20, 2024

Do we also need to change the unversioned docs though?

yes @nilekhc can you pls also update https://github.com/open-policy-agent/gatekeeper/blob/master/website/docs/externaldata.md#sample-providers

Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
@nilekhc nilekhc force-pushed the update-external-data-provider branch from e20e12b to a29f21d Compare April 30, 2024 19:33
Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ritazh ritazh merged commit e9d94c6 into open-policy-agent:master May 1, 2024
4 checks passed
@nilekhc nilekhc deleted the update-external-data-provider branch May 1, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

external data provider for Kubernetes API
3 participants