Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readiness tracker collect invalid expects #750

Merged
merged 11 commits into from
Jul 29, 2020
Merged

Readiness tracker collect invalid expects #750

merged 11 commits into from
Jul 29, 2020

Commits on Jul 28, 2020

  1. Collect Expectations for deleted obects in readiness tracker 

    Signed-off-by: Bryce Cronkite-Ratcliff <brycecr@gmail.com>
    @brycecr
    brycecr committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    d979421 View commit details
    Browse the repository at this point in the history

  2. Add test for collecting deleted objects in readiness tracker 

    Signed-off-by: Bryce Cronkite-Ratcliff <brycecr@gmail.com>
    @brycecr
    brycecr committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    b2daaa2 View commit details
    Browse the repository at this point in the history

  3. Fix linting errors 

    (misspellings, unneceesary guard around delete)

Signed-off-by: Bryce Cronkite-Ratcliff <brycecr@gmail.com>
    @brycecr
    brycecr committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    d3e0d95 View commit details
    Browse the repository at this point in the history

  4. Relax CollectDeleted test 

    There's no real need to check the number of resources tracked,
only that we are tracking and deleting something. This makes the
test less sensitive to changes in the testdata and leaked state
from different tests.

Also fix a couple log.Error calls

Signed-off-by: Bryce Cronkite-Ratcliff <brycecr@gmail.com>
    @brycecr
    brycecr committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    b44b777 View commit details
    Browse the repository at this point in the history

  5. address nits, readability, and restructure initial go func 

    Signed-off-by: Bryce Cronkite-Ratcliff <brycecr@gmail.com>
    @brycecr
    brycecr committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    581929e View commit details
    Browse the repository at this point in the history

  6. add retry backoff wrapper for lister 

    Signed-off-by: Bryce Cronkite-Ratcliff <brycecr@gmail.com>
    @brycecr
    brycecr committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    03d4cbf View commit details
    Browse the repository at this point in the history

  7. go mod tidy 

    Signed-off-by: Bryce Cronkite-Ratcliff <brycecr@gmail.com>
    @brycecr
    brycecr committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    99c0368 View commit details
    Browse the repository at this point in the history

  8. change retry to retryLister 

    Signed-off-by: Bryce Cronkite-Ratcliff <brycecr@gmail.com>
    @brycecr
    brycecr committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    3036da3 View commit details
    Browse the repository at this point in the history

  9. add cleanup func param to collectForObjectTracker 

    Signed-off-by: Bryce Cronkite-Ratcliff <brycecr@gmail.com>
    @brycecr
    brycecr committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    4de5072 View commit details
    Browse the repository at this point in the history

  10. rerun flaky tests 

    Signed-off-by: Bryce Cronkite-Ratcliff <brycecr@gmail.com>
    @brycecr
    brycecr committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    34a4285 View commit details
    Browse the repository at this point in the history

  11. rerun flaky tests 

    Signed-off-by: Bryce Cronkite-Ratcliff <brycecr@gmail.com>
    @brycecr
    brycecr committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    2c3ef6c View commit details
    Browse the repository at this point in the history