Do not trigger a watch of pods for status owner ref #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Smythe <smythe@google.com>
Signed-off-by: Max Smythe <smythe@google.com>
Signed-off-by: Max Smythe <smythe@google.com>
|
that did the trick!
|
grosser
reviewed
Jul 27, 2020
| @@ -317,14 +321,28 @@ func (r *ReconcileConstraint) Reconcile(request reconcile.Request) (reconcile.Re | |||
| } | |||
|
|
|||
| func (r *ReconcileConstraint) defaultGetPod() (*corev1.Pod, error) { | |||
There was a problem hiding this comment.
can this be reused between the 2 controllers without copy-pasting it ?
There was a problem hiding this comment.
Unified the two functions, PTAL.
grosser
approved these changes
Jul 27, 2020
Signed-off-by: Max Smythe <smythe@google.com>
grosser
approved these changes
Jul 27, 2020
Signed-off-by: Max Smythe <smythe@google.com>
Signed-off-by: Max Smythe <smythe@google.com>
Divya063
pushed a commit
to Divya063/gatekeeper
that referenced
this pull request
Jul 28, 2020
…t#754) * Do not trigger a watch of pods for status owner ref Signed-off-by: Max Smythe <smythe@google.com> * Run goimports Signed-off-by: Max Smythe <smythe@google.com> * Do not use cache for retrieving pod Signed-off-by: Max Smythe <smythe@google.com> * Unify getPod and add flag to toggle enabling fake get pod Signed-off-by: Max Smythe <smythe@google.com> * Fix lint errors Signed-off-by: Max Smythe <smythe@google.com> * Fix nil pointer error Signed-off-by: Max Smythe <smythe@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Max Smythe smythe@google.com
What this PR does / why we need it:
This PR should avoid triggering a watch of all pods in the cluster when getting the self-referenced pod.
This also re-adds the ability to run Gatekeeper outside of a Kubernetes cluster for testing purposes, per #738
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #742
Special notes for your reviewer: