Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cert-controller order in go.mod #965

Merged
merged 2 commits into from Nov 17, 2020

Conversation

mmirecki
Copy link
Contributor

Change the place of cert-rotator in go.mod, which now gets updated in every build.
Also update the cert-controller entry in go.sum

Signed-off-by: mmirecki <mmirecki@redhat.com>
Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-io
Copy link

Codecov Report

Merging #965 (4b4e279) into master (cff9cdd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #965   +/-   ##
=======================================
  Coverage   43.60%   43.60%           
=======================================
  Files          52       52           
  Lines        3222     3222           
=======================================
  Hits         1405     1405           
  Misses       1622     1622           
  Partials      195      195           
Flag Coverage Δ
unittests 43.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cff9cdd...4b4e279. Read the comment docs.

@shomron
Copy link
Contributor

shomron commented Nov 16, 2020

@mmirecki I'm curious which version of go you're compiling with? Using 1.15.4, I don't see any reordering happening after a build.

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, leaving open as I'm also curious about the answer to shomron@'s question

@mmirecki
Copy link
Contributor Author

@mmirecki I'm curious which version of go you're compiling with? Using 1.15.4, I don't see any reordering happening after a build.

I updated the env to go1.15.5, and it's working fine too (no reordering).
I would still keep the PR, as there is a little value in keeping the deps orderd and removing old hashes.

@ritazh ritazh merged commit 60b11a7 into open-policy-agent:master Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants