Implemented optional use of existing secret for mgmt token #175
Conversation
amentebekele-okta
force-pushed
the
master
branch
from
2195524
to
74c91a5
Compare
|
@eshepelyuk when you get a chance, can I get a review for this. Thanks! |
|
@eshepelyuk Thanks for taking a look. I have added the lint and e2e tests. |
amentebekele-okta
force-pushed
the
master
branch
from
09a9600
to
d7d9842
Compare
charts/opa-kube-mgmt/values.yaml
Outdated
| # Used for setting the mgmt token used for authz instead of auto generated default | ||
| # mgmtToken: | ||
| # secretName: name of the secret | ||
| # secretKey: key from the secret |
There was a problem hiding this comment.
I suggest to create a default value for secretKey, so this field can be optional.
There was a problem hiding this comment.
Instead of introducing setup.sh and changes to e2e pipeline, use special e2e helm template charts/opa-kube-mgmt/templates/ingressroute.yaml.
Add there a new block that renders your secret, if a new, e2e only value is set, that you can add to values.yaml of your e2e test.
I can see that would also work. But, using the e2e flag, will make it render for all the other tests which don't use this secret. However, I think the |
Apparently, as I already mentioned, you have to introduce another value that will trigger render of the secret. |
Sure, no problem. I have pushed changes. |
Signed-off-by: Amente Bekele <amente.bekele@okta.com>
amentebekele-okta
force-pushed
the
master
branch
from
bb91679
to
cead98b
Compare
|
Hello @amentebekele-okta |
This PR adds an optional functionality to mount and use existing secret as mgmt-token for the helm chart, instead of generating a new one. This is useful when specifying more than 1 replica and we want them to use the same token.