fix: helm chart serviceMonitor port definition #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current `ServiceMonitor` template defines `http` as destination port for scraping metrics data, which is not set in the `Service` manifest, however `diag` is. This commit updates the `ServiceMonitor` manifest to use `diag` port, which is exposed when prometheus is enabled. Signed-off-by: Jernej Porenta <jernej.porenta@3fs.si>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current
ServiceMonitortemplate defineshttpas destination port for scraping metrics data, which is not set in theServicemanifest.This commit updates the
ServiceMonitormanifest to usediagport, which is exposed when prometheus is enabled.