allow custom label openpolicyagent.org/policy=rego #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/custom label. Signed-off-by: Kirk Patton <kpatton@verizonmedia.com>
tsandall
reviewed
Mar 15, 2021
cmd/kube-mgmt/main.go
Outdated
Comment on lines
78
to
79
| rootCmd.Flags().StringVarP(¶ms.policyLabel, "policy-label", "", "", "replace label openpolicyagent.org/policy") | ||
| rootCmd.Flags().StringVarP(¶ms.policyValue, "policy-value", "", "", "replace value rego") |
There was a problem hiding this comment.
How about we make the default values "openpolicyagent.org/policy" and "rego". Then we just have to plumb the values into the configmap watcher.
pkg/configmap/configmap.go
Outdated
| return "", err | ||
| } | ||
|
|
||
| policyLabelKey = key |
There was a problem hiding this comment.
Hrmmm. Those values were defined as globals because they weren't changing (i.e., they ought to have been consts). I would rather make the main() function pass the values into the watcher as parameters rather than relying on mutable global state.
Signed-off-by: Kirk Patton <kpatton@verizonmedia.com>
|
@tsandall does the update address your noted feedback? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--policy-label=my.org/policy
--policy-value=mutating
I would like two run separate OPA servers using the same policy namespace. Currently openpolicyagent.org/policy=rego" is hard coded.