Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Angular by exposing both CommonJS and ESM imports #190

Merged
merged 2 commits into from May 6, 2022
Merged

Conversation

maucaro
Copy link
Contributor

@maucaro maucaro commented Apr 28, 2022

As discussed, these changes allow for easier consumption from environments other than Node (Angular for example) by exposing both CommonJS and ES module imports as described in Conditional Exports.

@maucaro
Copy link
Contributor Author

maucaro commented Apr 29, 2022

Second commit removed the 'util' shim for Node 10 compatibility.

@srenatus
Copy link
Contributor

srenatus commented May 4, 2022

Thanks, this looks good to me. Could you revisit those commit messages, though, they seem to be missing titles...

@aron Any concerns re: removing those keys from the package.json you'd be aware of?

@maucaro maucaro changed the title Signed-off-by: Mauricio Caro <maucaro@outlook.com> Signed-off-by: Mauricio Caro <maucaro@outlook.com> Simplifying exports to enable broader usage May 4, 2022
@srenatus
Copy link
Contributor

srenatus commented May 6, 2022

I meant these two commits: https://github.com/open-policy-agent/npm-opa-wasm/pull/190/commits

But it's OK I can squash and merge them.

@srenatus
Copy link
Contributor

srenatus commented May 6, 2022

Nope I can't do that without the DCO check: please have another look here -- https://github.com/open-policy-agent/npm-opa-wasm/pull/190/checks?check_run_id=6235937268

@maucaro
Copy link
Contributor Author

maucaro commented May 6, 2022

I don't know how to fix the DCO check. If you look at the message, it says it is expecting "maucaro@google.com" instead of "maucaro@outlook.com" yet "maucaro@outlook.com" is my verified email in my profile. Happy to fix it, just don't know how.

@srenatus
Copy link
Contributor

srenatus commented May 6, 2022

I suspect it's the commits author line. You can't inspect that via GitHub, but git log will tell you.

…aro <maucaro@outlook.com>

Signed-off-by: Mauricio Caro <maucaro@outlook.com>
…aro <maucaro@outlook.com>

Signed-off-by: Mauricio Caro <maucaro@outlook.com>
@maucaro
Copy link
Contributor Author

maucaro commented May 6, 2022

Looks like we are good now!

@srenatus srenatus merged commit bd6f38f into open-policy-agent:main May 6, 2022
@srenatus srenatus changed the title Signed-off-by: Mauricio Caro <maucaro@outlook.com> Simplifying exports to enable broader usage support angularjs by exposing both CommonJS and ESM imports May 18, 2022
@srenatus srenatus changed the title support angularjs by exposing both CommonJS and ESM imports Support Angular by exposing both CommonJS and ESM imports May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants