builtins: remove superfluous implementations #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srenatus
force-pushed
the
sr/cleanup-builtins
branch
2 times, most recently
from
85644cb
to
102fc25
Compare
tsandall
approved these changes
Jul 23, 2021
|
Hrmm we could hold this until #14 is dealt with. 💭 |
These have been no longer needed for a long time now. The wasm modules built with OPA have native implementations for those builtins, and the code here is never called. Fixes #15. Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
srenatus
force-pushed
the
sr/cleanup-builtins
branch
from
102fc25
to
4f8d062
Compare
|
Now that #64 is in, I've rebased this: it should still pass, and thus prove that the hereby removed builtin implementations haven't had any effect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These have been no longer needed for a long time now. The wasm modules
built with OPA have native implementations for those builtins, and the
code here is never called.
Fixes #15.