Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bundle.NewCustomReader requires unexported parameter #1840

Closed
istalker2 opened this issue Oct 12, 2019 · 0 comments · Fixed by #1902
Closed

bundle.NewCustomReader requires unexported parameter #1840

istalker2 opened this issue Oct 12, 2019 · 0 comments · Fixed by #1902
Assignees
@patrick-east
Labels
bug
Projects
Open Policy Agent

Comments

@istalker2
Copy link
Contributor

istalker2 commented Oct 12, 2019 •
edited

bundle.NewReader is deprecated in favor of bundle.NewCustomReader:

Deprecated: Use NewCustomReader with TarballLoader instead

However, TarballLoader is not publicly accessible as it located under internal folder.
@istalker2 istalker2 changed the title bundles.NewCustomReader requires unexported parameter bundle.NewCustomReader requires unexported parameter Oct 12, 2019
@patrick-east patrick-east self-assigned this Oct 14, 2019
@patrick-east patrick-east added this to To do in Open Policy Agent via automation Oct 14, 2019
@patrick-east patrick-east moved this from To do to Planned in Open Policy Agent Nov 13, 2019
patrick-east added a commit to patrick-east/opa that referenced this issue Nov 13, 2019
@patrick-east
bundle: Make the DirectoryLoader public
36046b3 
Previously we had it in an internal package but used by a public API,
which basically means it can't actually be used outside of OPA.
Initial thinking was that this was an OK situation, but by popular
demand we are making it available to everyone so OPA as a lib users
can use the bundle loading API's.

Fixes: open-policy-agent#1840
Signed-off-by: Patrick East <east.patrick@gmail.com>
@patrick-east patrick-east mentioned this issue Nov 13, 2019
Merged
@patrick-east patrick-east moved this from Planned to In progress in Open Policy Agent Nov 13, 2019
Open Policy Agent automation moved this from In progress to Done Nov 14, 2019
patrick-east added a commit that referenced this issue Nov 14, 2019
@patrick-east
bundle: Make the DirectoryLoader public
8688bc0 
Previously we had it in an internal package but used by a public API,
which basically means it can't actually be used outside of OPA.
Initial thinking was that this was an OK situation, but by popular
demand we are making it available to everyone so OPA as a lib users
can use the bundle loading API's.

Fixes: #1840
Signed-off-by: Patrick East <east.patrick@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patrick-east patrick-east

Labels
bug
Projects
Open Policy Agent
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bundle: Make the DirectoryLoader public patrick-east/opa
2 participants
@istalker2 @patrick-east