Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused assignment in example Kubernetes policy #4778

Closed
anderseknert opened this issue Jun 14, 2022 · 0 comments · Fixed by #4783
Closed

Unused assignment in example Kubernetes policy #4778

anderseknert opened this issue Jun 14, 2022 · 0 comments · Fixed by #4783
Labels
bug docs good first issue

Comments

@anderseknert
Copy link
Member

This policy example contains unused assignment: https://www.openpolicyagent.org/docs/latest/kubernetes-tutorial/#policy-1-restrict-hostnames

str_parts := split(str, ".")
n_pattern_parts := count(pattern_parts)
n_str_parts := count(str_parts)

Pasting the policy into the Rego playground and evaluating it with strict mode shows this. We should have those removed from the example.
@Joffref Joffref mentioned this issue Jun 16, 2022
Merged
Joffref added a commit to Joffref/opa that referenced this issue Jun 16, 2022
@Joffref
Removing unused assignement
5fd2b3b 
Ref : open-policy-agent#4778
Signed-off-by: Sugate <51022808+Joffref@users.noreply.github.com>
anderseknert pushed a commit that referenced this issue Jun 16, 2022
@Joffref
docs: remove unused assignement in Kubernetes tutorial example (#4783)
8fe8035 
Fixes #4778

Signed-off-by: Sugate <51022808+Joffref@users.noreply.github.com>
Joffref added a commit to Joffref/opa that referenced this issue Jul 11, 2022
@Joffref
Removing unused assignement
a82467b 
Ref : open-policy-agent#4778
Signed-off-by: Sugate <51022808+Joffref@users.noreply.github.com>
Signed-off-by: Joffref <mariusjoffre@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug docs good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: remove unused assignement in Kubernetes tutorial example Joffref/opa
1 participant
@anderseknert