Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add server test case for the bundle update - query API handler scenario #4792

Closed
ashutosh-narkar opened this issue Jun 17, 2022 · 0 comments · Fixed by #6251
Closed

Add server test case for the bundle update - query API handler scenario #4792

ashutosh-narkar opened this issue Jun 17, 2022 · 0 comments · Fixed by #6251
Assignees
@ashutosh-narkar
Labels
runtime
Projects
Open Policy Agent

Comments

@ashutosh-narkar
Copy link
Member

The query API handler (ie. v1DataPost) should accept client requests even when OPA is performing bundle activation. A recent change updated v1DataPost handler to open a read txn on the store which would prevent api requests from being blocked while a bundle is activating. We should add a server test to exercise this scenario. The test case would open a write transaction on the store and then simulate client requests to ensure that the server still processes them.
@ashutosh-narkar ashutosh-narkar added this to Backlog in Open Policy Agent via automation Jun 17, 2022
@ashutosh-narkar ashutosh-narkar self-assigned this Jun 17, 2022
ashutosh-narkar added a commit to ashutosh-narkar/opa that referenced this issue Sep 26, 2023
@ashutosh-narkar
server: Add test case for bundle update - query API handler scenario
5d089fe 
This test case exercises the scenario when a bundle is being written
to the store (ie. active write transaction) and the OPA server handling
a policy eval request at the same time. The former should not block
the later.

Fixes: open-policy-agent#4792

Signed-off-by: Ashutosh Narkar <anarkar4387@gmail.com>
@ashutosh-narkar ashutosh-narkar mentioned this issue Sep 26, 2023
Merged
@ashutosh-narkar ashutosh-narkar moved this from Backlog to In Progress in Open Policy Agent Sep 26, 2023
ashutosh-narkar added a commit to ashutosh-narkar/opa that referenced this issue Sep 27, 2023
@ashutosh-narkar
server: Add test case for bundle update - query API handler scenario
4143eb9 
This test case exercises the scenario when a bundle is being written
to the store (ie. active write transaction) and the OPA server handling
a policy eval request at the same time. The former should not block
the later.

Fixes: open-policy-agent#4792

Signed-off-by: Ashutosh Narkar <anarkar4387@gmail.com>
Open Policy Agent automation moved this from In Progress to Done Sep 27, 2023
ashutosh-narkar added a commit that referenced this issue Sep 27, 2023
@ashutosh-narkar
server: Add test case for bundle update - query API handler scenario
974586e 
This test case exercises the scenario when a bundle is being written
to the store (ie. active write transaction) and the OPA server handling
a policy eval request at the same time. The former should not block
the later.

Fixes: #4792

Signed-off-by: Ashutosh Narkar <anarkar4387@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashutosh-narkar ashutosh-narkar

Labels
runtime
Projects
Open Policy Agent
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

server: Add test case for bundle update - query API handler scenario ashutosh-narkar/opa
1 participant
@ashutosh-narkar