bundle_failed_load_counter broken for bundles without revision

[jkbschmid]

Short description

At the moment, the bundle_failed_load_counter metric is broken for bundles without a revision field in their .manifest files.

To determine whether a bundle load failed and the bundle_failed_load_counter should be incremented, OPA currently uses bundle.Code and bundle.ActiveRevision:

opa/plugins/status/plugin.go

Line 484 in e9d8353

if bundle.Code == "" && bundle.ActiveRevision != "" {

However, according to the docs, providing a .manifest file as well as specifying a revision is optional.

So if there's a bundle without a revision, bundle.ActiveRevision will be "" and OPA will always assume a bundle load failed and bundle_failed_load_counter will be incremented on every bundle load, regardless of success.

• OPA version: main and v0.40
• Prometheus bundle metrics enabled

Expected behavior

I'd expect bundle_failed_load_counter not to rely on the the revision of a bundle.
I'd be happy to provide a fix, e.g. like

if bundle.Code == "" && !bundle.LastSuccessfulActivation.IsZero() {

[srenatus]

Sounds reasonable! It would be nice if you could contribute a fix. 👍