Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nd_builtin_cache configuration isn't being honored through the discovery config #5457

Closed
asadali opened this issue Dec 7, 2022 · 0 comments · Fixed by #5468
Closed

nd_builtin_cache configuration isn't being honored through the discovery config #5457

asadali opened this issue Dec 7, 2022 · 0 comments · Fixed by #5468
Labels
bug
Projects
Open Policy Agent

Comments

@asadali
Copy link
Member

asadali commented Dec 7, 2022 •
edited

Short description

The nd_builtin_cache configuration setting works as expected when specified directly in the opa configuration file. However, when supplied through the discovery config, it does not take effect on the opa decision logs. This means that the nd_builtin_cache values aren't recorded as part of the decisions.

Expected behavior

The setting should work when supplied through discovery config.

Additional context

edit: It will be helpful if the fix is patched to 0.46 release as well. (no longer needed)
@asadali asadali added the bug label Dec 7, 2022
@ashutosh-narkar ashutosh-narkar added this to Backlog in Open Policy Agent via automation Dec 8, 2022
@ashutosh-narkar ashutosh-narkar moved this from Backlog to In Progress in Open Policy Agent Dec 8, 2022
@ashutosh-narkar ashutosh-narkar mentioned this issue Dec 9, 2022
Merged
philipaconrad pushed a commit to ashutosh-narkar/opa that referenced this issue Dec 19, 2022
@ashutosh-narkar @philipaconrad
WIP: Add support to enable nd cache via discovery
3930b30 
Fixes: open-policy-agent#5457
Signed-off-by: Ashutosh Narkar <anarkar4387@gmail.com>
Open Policy Agent automation moved this from In Progress to Done Dec 19, 2022
philipaconrad added a commit that referenced this issue Dec 19, 2022
@ashutosh-narkar @philipaconrad
Add support to enable ND builtin cache via discovery (#5468)
d12e959 
This commit adds support for enabling/disabling the ND builtin
cache via the OPA `discovery` plugin.

Fixes: #5457

Signed-off-by: Ashutosh Narkar <anarkar4387@gmail.com>
Signed-off-by: Philip Conrad <philipaconrad@gmail.com>
Co-authored-by: Philip Conrad <philipaconrad@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
Open Policy Agent
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support to enable ND builtin cache via discovery ashutosh-narkar/opa
1 participant
@asadali