Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ast/visit should traverse into symbols on SomeDecl nodes #5480

Closed
tsandall opened this issue Dec 13, 2022 · 0 comments · Fixed by #5515
Closed

ast/visit should traverse into symbols on SomeDecl nodes #5480

tsandall opened this issue Dec 13, 2022 · 0 comments · Fixed by #5515
Labels
bug

Comments

@tsandall
Copy link
Member

Currently the ast/visit implementation doesn't traverse into the symbols on SomeDecl nodes. Callers providing their own visitor implementation for static analysis will find this surprising. The workaround for the time being is to have the caller manually deal with SomeDecl nodes, but it would be better if the ast/visit implementations handled this.
@tsandall tsandall added the bug label Dec 13, 2022
srenatus added a commit to srenatus/opa that referenced this issue Jan 2, 2023
@srenatus
ast/visit: add SomeDecl to visitor walks
f4a4dec 
These had been overlooked, it seems. Adjusted the test element counts
for the new nodes getting recorded.

It seems like there's no test coverage for the deprecated ast.Walk() and
ast.WalkBeforeAndAfter() methods.

Fixes open-policy-agent#5480.

Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
@srenatus srenatus mentioned this issue Jan 2, 2023
Merged
srenatus added a commit that referenced this issue Jan 2, 2023
@srenatus
ast/visit: add SomeDecl to visitor walks (#5515)
2b8cbda 
These had been overlooked, it seems. Adjusted the test element counts
for the new nodes getting recorded.

It seems like there's no test coverage for the deprecated ast.Walk() and
ast.WalkBeforeAndAfter() methods.

Fixes #5480.

Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
harikannan512 pushed a commit to harikannan512/opa that referenced this issue Jan 3, 2023
@srenatus
ast/visit: add SomeDecl to visitor walks (open-policy-agent#5515)
3969918 
These had been overlooked, it seems. Adjusted the test element counts
for the new nodes getting recorded.

It seems like there's no test coverage for the deprecated ast.Walk() and
ast.WalkBeforeAndAfter() methods.

Fixes open-policy-agent#5480.

Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
Signed-off-by: harikannan <hariprasad.kannan@wexinc,com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ast/visit: add SomeDecl to visitor walks srenatus/opa
1 participant
@tsandall