Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-cubic cube described in policy-language.md #6206

Closed
rbanffy opened this issue Sep 4, 2023 · 3 comments
Closed

Non-cubic cube described in policy-language.md #6206

rbanffy opened this issue Sep 4, 2023 · 3 comments

Comments

@rbanffy
Copy link

rbanffy commented Sep 4, 2023

Short description

In /docs/content/policy-language.md, (https://www.openpolicyagent.org/docs/latest/policy-language/#sets) the cube described is a very weird one. One would assume that little bit of surreal (a 3x4x5 "cube") is done on purpose. Should it be fixed?

Steps To Reproduce

  1. Open https://www.openpolicyagent.org/docs/latest/policy-language/#sets
  2. Picture a 3x4x5 cube

Expected behavior

It should be cubic.

Additional context

https://en.wikipedia.org/wiki/Cube

@rbanffy rbanffy added the bug label Sep 4, 2023
@srenatus
Copy link
Contributor

srenatus commented Sep 4, 2023

Good point! Let's use a word that describes the thing better. It's not a cube. I guess it would make sense to compare two sets, like, a cube's edge lengths would be a one-element set, whereas another three-dimensional body (rectangular cuboid) would have an edge-length-set of more than one element... Or let's go with fruit or something. 😄

@rbanffy
Copy link
Author

rbanffy commented Sep 4, 2023

I thought about brick, but rectangular_cuboid sounds much more precise. I'll try to find the documentation on how to actually run the documentation, as it seems it's evaluated when rendered to HTML (and that changes what I'd need to write).

@stale
Copy link

stale bot commented Oct 4, 2023

This issue has been automatically marked as inactive because it has not had any activity in the last 30 days. Although currently inactive, the issue could still be considered and actively worked on in the future. More details about the use-case this issue attempts to address, the value provided by completing it or possible solutions to resolve it would help to prioritize the issue.

@stale stale bot added the inactive label Oct 4, 2023
kd-labs added a commit to kd-labs/opa that referenced this issue Apr 10, 2024
Signed-off-by: kunal.das <kd.kunaldas92@gmail.com>
tsidebottom pushed a commit to tsidebottom/opa- that referenced this issue Apr 17, 2024
Signed-off-by: kunal.das <kd.kunaldas92@gmail.com>
Signed-off-by: Thomas Sidebottom <thomas.sidebottom@va.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants