-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add out-of-the-box zap logger #6499
Comments
💭 Now what "log/slog" has appeared, would that provide a no-dependencies common ground for multiple logging implementations to plug in? Honest question, I haven't played with it much yet. |
Signed-off-by: Alexander Mckenzie-Kelly <alexmk@uk.ibm.com> open-policy-agent#6499
Add a unit test Add godoc comments Add READMEs Signed-off-by: Alexander Mckenzie-Kelly <alexmk@uk.ibm.com> open-policy-agent#6499
No need to be ahead of the min version for opa Signed-off-by: Alexander Mckenzie-Kelly <alexmk@uk.ibm.com> open-policy-agent#6499
|
Ah, minimal go version. Yeah, thanks for checking that. |
open-policy-agent/opa#6499 Signed-off-by: Alexander Mckenzie-Kelly <alexmk@uk.ibm.com>
open-policy-agent/opa#6499 Signed-off-by: Alexander Mckenzie-Kelly <alexmk@uk.ibm.com>
What is the underlying problem you're trying to solve?
Embedding OPA as an SDK in a service currently means either:
This is all surmountable but it may be a nice quality of life improvement to have common log implementation wrappers in the core OPA library.
Describe the ideal solution
Ideally I could just do something like:
and get on with my day.
Describe a "Good Enough" solution
Unfortunately the
SetLevel
function means you also need to pass azap.AtomicLevel
:A better solution would be very welcome.
Additional Context
I have a proposed implementation which I will pull request shortly.
The text was updated successfully, but these errors were encountered: