wasm: Add support for set values #1429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sets are not unified recursively so variables contained in sets need to be checked against the save set recursively unlike other terms. These changes just update the save set check to take sets into account. Signed-off-by: Torin Sandall <torinsandall@gmail.com>
These changes add support for set values in preparation for rules support. With these changes in place we will be able to compile all rules to wasm. These changes mostly duplicate existing code paths for object values but specialize them for sets. Sets are implemented as sorted lists for now. Set operations are O(n) for now. These changes are not accompanied with end-to-end tests due to partial evaluation. I.e., if set literals are constructed, any test operations like iteration will be unrolled by partial evaluation and since input can only contain JSON values, we don't have a way to fully exercise the set values. Once rules are supported we can improve this. Signed-off-by: Torin Sandall <torinsandall@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add support for set values. In the process I discovered a bug in partial evaluation of unification with two sets. This PR also contains a commit resolving that issue.