docs: Use a single value for algolia version meta #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As-is we have an array like `["v0.13.4", "latest"]` but it seems that we aren't referencing it as such, its trying to compare a string version. It looks like on the `latest` urls we would set the facetFilter to be the explicit version, so we'll just stick with that for the meta tags too. Signed-off-by: Patrick East <east.patrick@gmail.com>
patrick-east
force-pushed
the
doc-search-fixup
branch
from
64cca61
to
d247c41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As-is we have an array like `["v0.13.4", "latest"] but it seems that
we aren't referencing it as such, its trying to compare a string
version.
It looks like on the
latesturls we would set the facetFilter tobe the explicit version, so we'll just stick with that for the meta
tags too.
Ref: https://discourse.algolia.com/t/docsearch-isnt-showing-results-on-newer-version-of-docs/8345/3