types: Sort any elements during construction #3805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srenatus
previously approved these changes
Sep 18, 2021
|
Something in CI got confused here, it seems. Could be related to my recent change, or have something to do with the branch not being in a fork ...? I'll have a look later |
|
Looks like the test failures are genuine -- the ordering of the types has changed. Could you have another look, please, @tsandall? As a side note, we should add a |
This changes updates the implementation of the any type to sort elements during construction. This way the Compare() function does not have to sort elements before recursing (which can result in data races if global type instances from the built-in function declarations or elsewhere are compared.) Fixes #3793 Signed-off-by: Torin Sandall <torinsandall@gmail.com>
Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
|
@tsandall I've picked this up -- by chance it was pushed to this origin, so I've taken care of the tests and rebased it. |
dolevf
pushed a commit
to dolevf/opa
that referenced
this pull request
Nov 4, 2021
* types: Sort any elements during construction This changes updates the implementation of the any type to sort elements during construction. This way the Compare() function does not have to sort elements before recursing (which can result in data races if global type instances from the built-in function declarations or elsewhere are compared.) Fixes open-policy-agent#3793 * capabilities.json: changed ordering * internal/presentation: fix json error output Co-authored-by: Torin Sandall <torinsandall@gmail.com> Co-authored-by: Stephan Renatus <stephan.renatus@gmail.com> Signed-off-by: Torin Sandall <torinsandall@gmail.com> Signed-off-by: Dolev Farhi <farhi.dolev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes updates the implementation of the any type to sort
elements during construction. This way the Compare() function does not
have to sort elements before recursing (which can result in data races
if global type instances from the built-in function declarations or
elsewhere are compared.)
Fixes #3793
Signed-off-by: Torin Sandall torinsandall@gmail.com