plugins/rest: refactor AWS credentials provider config validation #4081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
The TestNew case of rest_test.go had failed when run in isolation, but passed when running all of the packages tests. With these changes to how env vars are handled, it passed both alone and when run with all the other tests. Also migrated the TestWebIdentityCredentialService test to use test.WithTempFS instead of dealing with the files itself. Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
srenatus
force-pushed
the
sr/plugins/rest/refactor-config-validation
branch
from
7fd6e9c
to
94b8c59
Compare
tsandall
reviewed
Dec 7, 2021
Comment on lines
+552
to
+556
| cfgs := map[bool]int{} | ||
| cfgs[ap.AWSEnvironmentCredentials != nil]++ | ||
| cfgs[ap.AWSMetadataCredentials != nil]++ | ||
| cfgs[ap.AWSWebIdentityCredentials != nil]++ | ||
| cfgs[ap.AWSProfileCredentials != nil]++ |
tsandall
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cleanup in the code and tests, follow-up to #2786 .
The tests can now run in isolation because one test case shouldn't depend on the env vars another test case has set.