planner: if dynamic call fails, or dereferencing data fails, break to undefined #4275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srenatus
force-pushed
the
sr/planner/fix-break-index
branch
from
3853040
to
eb3ff79
Compare
srenatus
changed the title
srenatus
force-pushed
the
sr/planner/fix-break-index
branch
from
eb3ff79
to
b627194
Compare
srenatus
changed the title
srenatus
force-pushed
the
sr/planner/fix-break-index
branch
2 times, most recently
from
4c7f326
to
97f4bf4
Compare
…fined Due to excessive nesting of blocks, the break statement wasn't breaking out of enough of them: this would this add an element to the result set when it should have turned into undefined. This was the case in two conditions: a. the dynamic lookup not finding a data function to call, and the resulting static data lookup failing to resolve the ref; or b. the dynamically called function returns undefined Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
srenatus
force-pushed
the
sr/planner/fix-break-index
branch
from
97f4bf4
to
34a9f9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to excessive nesting of blocks, the break statement wasn't breaking
out of enough of them: this would this add an element to the result set
when it should have turned into undefined.
This was the case in two conditions:
a. the dynamic lookup not finding a data function to call, and the resulting
static data lookup failing to resolve the ref; or
b. the dynamically called function returns undefined