Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import rule. Package should be ref #4690

Merged
merged 1 commit into from May 15, 2022

Conversation

mmzeeman
Copy link
Contributor

Small grammar fix in documentation. Fixes #4689

srenatus
srenatus previously approved these changes May 15, 2022
Copy link
Contributor

@srenatus srenatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch 👍

@srenatus
Copy link
Contributor

Could you please see after the DCO signed-off-by line? Details

Signed-off-by: Maas-Maarten Zeeman <mmzeeman@xs4all.nl>
@mmzeeman
Copy link
Contributor Author

Like that?

@srenatus
Copy link
Contributor

Exactly. Thanks!

@srenatus srenatus merged commit 4cb0c7b into open-policy-agent:main May 15, 2022
@srenatus
Copy link
Contributor

🤦 I've put a typo in the commit message when giving it a small copy-edit. Sorry about that.

@mmzeeman
Copy link
Contributor Author

mmzeeman commented May 15, 2022

Ah, such is life.

BTW... I also think there is an error in the infix-expr rule... The current form does not allow assignments like something := true or something_else = false.

Is there a grammar somewhere?

@mmzeeman
Copy link
Contributor Author

This rule also does not make any sense.

ref = ( var | array | object | set | array-compr | object-compr | set-compr | expr-call ) { ref-arg }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Include part of grammar is incorrect
2 participants