format: Output list and diff changes with --fail flag (#4508) #4710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anderseknert can we merge this ? |
…ent#4508) The change enables using --diff and --list together with --fail as discussed in open-policy-agent#4508, for example: $ opa fmt [path [...]] --list --fail; exit $? path/to/file-1.rego path/to/file-2.rego unexpected diff 2 Previously, the same command returned only the error: $ opa fmt [path [...]] --list --fail; exit $? unexpected diff 2 Signed-off-by: David Kuridža <david@kuridza.si>
|
@ashutosh-narkar sorry, not sure how I missed this. Yes, let's have this merged. |
anderseknert
approved these changes
Jun 5, 2022
|
Thanks for contributing, @davidkuridza 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change enables using --diff and --list together with --fail as discussed in #4508, for example:
Previously, the same command returned only the error: