topdown/parse_units: Use big.Rat for units parsing. #4857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipaconrad
requested review from
anderseknert
and removed request for
ashutosh-narkar
philipaconrad
force-pushed
the
issue-4856-inconsistent-units-rounding
branch
from
8030cb8
to
3c03733
Compare
srenatus
reviewed
Jul 7, 2022
philipaconrad
force-pushed
the
issue-4856-inconsistent-units-rounding
branch
from
3c03733
to
f920ac4
Compare
Previously, we used big.Float for units parsing, but this resulted in occasional rounding issues, due to values like 0.001 not being perfectly representable in floating-point format. This issue was fixed by switching units parsing to use big.Rat, since Rationals can generally handle such quantities with perfect precision. Fixes open-policy-agent#4856. Signed-off-by: Philip Conrad <philipaconrad@gmail.com>
philipaconrad
force-pushed
the
issue-4856-inconsistent-units-rounding
branch
from
f920ac4
to
6f8279d
Compare
srenatus
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we used
big.Floatfor units parsing, but this resulted in occasional rounding issues, due to values like0.001not being perfectly representable in floating-point format.This issue was fixed by switching units parsing to use
big.Rat, since Rationals can generally handle such quantities with perfect precision.A few new regression test cases have been added to the test suite, lifted almost verbatim from the original issue.
Fixes #4856.