topdown/type: Fix inconsistent is_<type> return values. #5064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes open-policy-agent#4943 Signed-off-by: Philip Conrad <philipaconrad@gmail.com>
philipaconrad
force-pushed
the
issue-4943-fix-is-valid-functions
branch
from
f0ee933
to
370c1a8
Compare
ashutosh-narkar
previously approved these changes
Aug 29, 2022
|
@ashutosh-narkar I forgot to fix the WASM side for these builtins. Fix coming shortly... |
Signed-off-by: Philip Conrad <philipaconrad@gmail.com>
srenatus
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the implementation of all of the
is_<type>builtins to consistently return only true/false values. This change is identical to the*.is_validbehavior changes that landed back in #4844.The affected builtins are:
is_arrayis_booleanis_nullis_numberis_objectis_setis_stringFixes: #4943