topdown+builtins: Block all ND builtins from partial eval. #5172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the `IgnoreDuringPartialEval` list in `ast/builtins`, and instead changes the partial evaluator to simply ignore all non-deterministic builtins. This keeps true to the intent of the original list, and reduces the potential for human error in maintenance in the future. Fixes: open-policy-agent#5171 Signed-off-by: Philip Conrad <philipaconrad@gmail.com>
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
anderseknert
approved these changes
Sep 23, 2022
srenatus
reviewed
Sep 23, 2022
| // IgnoreDuringPartialEval is a set of built-in functions that should not be | ||
| // evaluated during partial evaluation. These functions are not partially | ||
| // evaluated because they are not pure. | ||
| var IgnoreDuringPartialEval = []*Builtin{ |
There was a problem hiding this comment.
philipaconrad
added a commit
to philipaconrad/opa
that referenced
this pull request
Sep 23, 2022
This commit is a followup to the work done in PR open-policy-agent#5172, and partially reverts the changes there to avoid breaking library users of OPA. The fix restores the `IgnoreDuringPartialEval` list while still ensuring that non-deterministic builtins are not run during partial evaluation. Signed-off-by: Philip Conrad <philipaconrad@gmail.com>
srenatus
pushed a commit
that referenced
this pull request
Sep 26, 2022
This commit is a followup to the work done in PR #5172, and partially reverts the changes there to avoid breaking library users of OPA. The fix restores the `IgnoreDuringPartialEval` list while still ensuring that non-deterministic builtins are not run during partial evaluation. Signed-off-by: Philip Conrad <philipaconrad@gmail.com>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the
IgnoreDuringPartialEvallist inast/builtins, and instead changes the partial evaluator to simply ignore all non-deterministic builtins. This keeps true to the intent of the original list, and reduces the potential for human error in maintenance in the future.Fixes: #5171