default decision: differentiate between missing and undefined doc #5420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since "document missing or undefined" caused confusion, we can be more helpful and report whether the default decision document is missing, or whether it's there but undefined. I would probably have preferred for undefined to just result in an empty/undefined result, but that'd be quite a breaking change at this point in time, so hopefully this can at least make things a little less convoluted. Fixes open-policy-agent#5344 Signed-off-by: Anders Eknert <anders@eknert.com>
srenatus
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since "document missing or undefined" caused confusion, we can be more helpful and report whether the default decision document is missing, or whether it's there but undefined. I would probably have preferred for undefined to just result in an empty/undefined result, but that'd be quite a breaking change at this point in time, so hopefully this can at least make things a little less convoluted.
Fixes #5344
Signed-off-by: Anders Eknert anders@eknert.com