topdown: Specify host verification policy for http redirects #5546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if http redirects are enabled, we use the client's default redirect policy. We should instead check if the hosts http.send calls as part of the redirect are explictly allowed by the policy authors. This change updates the http client's CheckRedirect policy to verify the hosts the client calls when redirects are enabled. Fixes: open-policy-agent#5388 Signed-off-by: Ashutosh Narkar <anarkar4387@gmail.com>
srenatus
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if http redirects are enabled, we use the client's default redirect policy. We should instead check if the hosts http.send calls as part of the redirect are explictly allowed by the policy authors. This change updates the http client's CheckRedirect policy to verify the hosts the client calls when redirects are enabled.
Fixes: #5388
Signed-off-by: Ashutosh Narkar anarkar4387@gmail.com