perf: stream JSON in request body #5661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
srenatus
reviewed
Feb 15, 2023
| } | ||
| } else { | ||
| dec := util.NewJSONDecoder(r.Body) | ||
| if err := dec.Decode(&x); err != nil && err != io.EOF { |
There was a problem hiding this comment.
Doesn't the decoder accept multiple JSON documents that are concatenated? Not sure what happens if we send {}{}{} for input... Probably nothing of consequence.
There was a problem hiding this comment.
Seems like it's accepted, but only the first form is read, which seems acceptable to me
curl -d '{"foo": "bar"}{"x":1}' localhost:8181/v0/data{"decision_id":"...","input":{"foo":"bar"}
Similar to how open-policy-agent#5596 allowed streaming JSON in the response, do the same for the request. This has potentially bigger benefits, as the incoming request is commonly larger than the response (admission control, terraform, etc). Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert
force-pushed
the
json-stream-request
branch
from
fb69d13
to
9e2885d
Compare
srenatus
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to how #5596 allowed streaming JSON from the response, do the same for the request. This has potentially bigger benefits, as the incoming request is commonly larger than the response (admission control, terraform, etc).