ast: Fixing bug where comprehensions in rule else-heads weren't rewritten correctly #5772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanfylling
force-pushed
the
jf/5771/else_value_comprehension_bug
branch
from
4d38d94
to
e1970b8
Compare
johanfylling
force-pushed
the
jf/5771/else_value_comprehension_bug
branch
from
e1970b8
to
3c24900
Compare
…tten correctly Previously, vars in the rule head were only rewritten for the "primary" rule, and not for else branches. This has been fixed by walking the head of each branch and rewriting all vars found. Fixes: open-policy-agent#5771 Signed-off-by: Johan Fylling <johan.dev@fylling.se>
johanfylling
force-pushed
the
jf/5771/else_value_comprehension_bug
branch
from
3c24900
to
918aaa2
Compare
srenatus
approved these changes
Mar 21, 2023
johanfylling
added a commit
to johanfylling/opa
that referenced
this pull request
Mar 21, 2023
…tten correctly (open-policy-agent#5772) Previously, vars in the rule head were only rewritten for the "primary" rule, and not for else branches. This has been fixed by walking the head of each branch and rewriting all vars found. Fixes: open-policy-agent#5771 Signed-off-by: Johan Fylling <johan.dev@fylling.se> (cherry picked from commit bdd4604)
johanfylling
added a commit
that referenced
this pull request
Mar 21, 2023
…tten correctly (#5772) Previously, vars in the rule head were only rewritten for the "primary" rule, and not for else branches. This has been fixed by walking the head of each branch and rewriting all vars found. Fixes: #5771 Signed-off-by: Johan Fylling <johan.dev@fylling.se> (cherry picked from commit bdd4604)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, vars in the rule head were only rewritten for the "primary" rule,
and not for else branches. This has been fixed by walking the head of each branch
and rewriting all vars found.
Fixes: #5771