Add tracing to bundle/discovery download #5973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashutosh-narkar
previously approved these changes
Jun 6, 2023
plugins/plugins.go
Outdated
| @@ -365,6 +367,13 @@ func WithTracerProvider(tracerProvider *trace.TracerProvider) func(*Manager) { | |||
| } | |||
| } | |||
|
|
|||
| // DistributedTracingOpts sets the options to be used by distributed tracing. | |||
There was a problem hiding this comment.
Nit: DistributedTracingOpts -> WithDistributedTracingOpts
There was a problem hiding this comment.
Ah, ok missed that one(the convention differs on the place where it is used. Will change it for consistency
plugins/rest/rest_test.go
Outdated
| } | ||
|
|
||
| if exp, act := 1, mock.called; exp != act { | ||
| t.Errorf("calls to NewTransported: expected %d, got %d", exp, act) |
There was a problem hiding this comment.
Nit: Do you mean NewTransport?
There was a problem hiding this comment.
Yes, will change it at the place where it was copied from as well 😀
mjungsbluth
force-pushed
the
add_bundle_download_tracing
branch
from
70c5884
to
bf4063d
Compare
Signed-off-by: Magnus Jungsbluth <magnus@jungsbluth.de>
mjungsbluth
force-pushed
the
add_bundle_download_tracing
branch
from
bf4063d
to
fb2c054
Compare
ashutosh-narkar
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why the changes in this PR are needed?
Addresses #5967, adds the ability to configure distributed tracing options to plugin manager and rest client.
This allows using an existing distributed tracing infrastructure that is used for the http built-in for bundle downloads without relying in OpenTelemetry.
What are the changes in this PR?
tracing.Optionsto the relevant places to configure bundle download tracing