Fix for the issue when OPA throws misleading error (storage_not_found_error) #6007
+58
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anderseknert Hi, now the DCO check is passing. |
anderseknert
approved these changes
Jun 13, 2023
…_error) message while loading the delta bundle when persist property in config is true. The fix is to prevent the loading of delta bundle when persist is true and give a more clear error message. Fixes open-policy-agent#5959 Signed-off-by: Yogesh Sinha <sinhayogi@gmail.com>
anderseknert
force-pushed
the
remotes/origin/misleading_storage_not_found_error_fix
branch
from
006bc04
to
53feeff
Compare
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Hmm, the DCO check does not seem to be passing though. Not sure why, as the commit looks correct to me. @srenatus any idea? |
☝️ It's at the bottom for the DCO check, see here |
|
Huh, why would it expect that signoff? It's a different author 😄 |
|
Yup no idea. |
|
Also a different commit. So if push comes to shove, let's "Mark DCO as passed" using the UI. |
|
Done! Looks good to merge 👍 |
ashutosh-narkar
approved these changes
Jun 13, 2023
ashutosh-narkar
merged commit 18f9ef2
into
open-policy-agent:main
27 of 38 checks passed
yogisinha
deleted the
remotes/origin/misleading_storage_not_found_error_fix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the issue when OPA throws misleading error (storage_not_found_error) message while loading the delta bundle when persist property in config is true.
The fix is to prevent the loading of delta bundle when persist is true and give a more clear error message.
One Test function included TestReadWithPatchPersistProperty
Fixes #5959
Why the changes in this PR are needed?
a new persist property is created in Reader struct in bundle.go
WithBundlePersistence method is created on Reader
from download , this property is set in Reader
persist property is checked in Read() method to throw the error for delta bundles.