cmd: Fix opa test --ignore when used together with --bundle #6185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the --bundle flag, the opa test was ignoring (pun intented) the --ignore flags. Signed-off-by: João Paulo G. Brandt <joao@miro.com>
|
Linux test jobs are failing with the cause: Are this related with the change? |
@joaobrandt this is un-related to your change. |
| @@ -621,6 +621,7 @@ func LoadBundles(args []string, filter loader.Filter) (map[string]*bundle.Bundle | |||
| b, err := loader.NewFileLoader(). | |||
| WithProcessAnnotation(true). | |||
| WithSkipBundleVerification(true). | |||
| WithFilter(filter). | |||
ashutosh-narkar
approved these changes
Aug 28, 2023
ashutosh-narkar
merged commit 7bf2075
into
open-policy-agent:main
23 of 25 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why the changes in this PR are needed?
When used
opa test --bundlethe flags--ignorewere not used to filter the files.What are the changes in this PR?
Change the function
LoadBundlesto use the parameterfilterreceived.Notes to assist PR review:
None.
Further comments:
None.