Adding regression test for edge case where partial rule hides recursion cycle #6318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on cycle In OPA versions older than 0.56.0, a recursion cycle could be hidden to the compiler if partial object rules were "properly" organized. This issue was fixed in OPA 0.56.0 without being reported, this PR adds a regression test. Signed-off-by: Johan Fylling <johan.dev@fylling.se>
anderseknert
approved these changes
Oct 16, 2023
There is no issue to close. We're just adding a test for something we inadvertently fixed a few releases ago. I don't think this is something to advertise in the changelog, and it'd be weird to resolve an issue solved in another release .. Perhaps the proper course of action is to make a CVE for OPA <= 0.55.0, as discussed here. |
|
I meant that issue should be closed with this getting merged. Given what is required to trigger this, I don't think a CVE is warranted, as I later talked about in that same thread :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In OPA versions older than
0.56.0, a recursion cycle could be hidden to the compiler if partial object rules were "properly" organized. This issue was fixed in OPA0.56.0without being reported, this PR adds a regression test.