fmt: functions — don't add virtual = true value unless provided
#6323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anderseknert
commented
Oct 17, 2023
This is especially nice for functions doing pattern matching on equality in its arguments. Previously, we'd rewrite: ```rego f(1) ``` into ```rego f(1) = true ``` Now, we'll leave the shorter form alone, while still respecting explicit assignment, using either `=` or `:=`. Signed-off-by: Anders Eknert <anders@eknert.com>
anderseknert
force-pushed
the
fun-format
branch
from
fb17f48
to
f2f153e
Compare
srenatus
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is especially nice for functions doing pattern matching on equality in its arguments.
Previously, we'd rewrite:
into
Now, we'll leave the shorter form alone, while still respecting explicit assignment, using either
=or:=.